Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimal support for external extensions to pgjdbc datatypes #181

Closed
wants to merge 1 commit into from
Closed

minimal support for external extensions to pgjdbc datatypes #181

wants to merge 1 commit into from

Conversation

frode-carlsen
Copy link

Since #178 is on hold, I'd like to make the following minor changes to the existing project to ease creating external datatype extensions to the library.

@kdubb
Copy link
Member

kdubb commented Jun 16, 2015

Does this conform to our checkstyle? I thought "protected" should be on the same line as the method definition.

@frode-carlsen
Copy link
Author

interesting, it passed the checkstyle tests so looks like that's not enforced.
I used automated refactoring to make the change, so I have no qualms about changing it to be on the same line. Will check in

@jesperpedersen
Copy link
Contributor

@frode-carlsen Could you fix the indentation of the pom.xml file change ? Then rebase, and squash. Thanks

@frode-carlsen
Copy link
Author

ok, made some cosmetic changes to make it align same as plugins with above/below, but the whole pom.xml needs reformatting. It's a mix of tabs and spaces and improperly aligned child elements. Can do it here, but think perhaps it should be a different PR?

@jesperpedersen
Copy link
Contributor

@frode-carlsen Just format to spaces here, but squash your commits too

@frode-carlsen
Copy link
Author

how about this?

@jesperpedersen
Copy link
Contributor

Rebased, and merged. Thanks for your contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants